Nathan Rebours
Nathan Rebours
Thanks for taking interest in `ppxlib` and for reporting this! I'm not quite sure I understand the problem you ran into. Is it that you're trying to write a ppx...
I've taken a look at your repo. The failure with `ppx_repr` was expected, since the locations weren't marked as ghost anywhere, the location check failed because indeed the siblings had...
I just started working on a better AST pretty-printing utility for ppxlib here: #517. I'll try to use it to debug what's going on with ppx_fresh and get back to...
I just fixed it here: https://github.com/Kakadu/ppxlib_check_demo/pull/1 It was a simple bug and indeed the locations were off!
If you don't have any further questions, I think we can close this issue!
Yes that is indeed a problem, thanks for reporting it! Helpers for ppx authors definitely sounds like something we should provide to help them write code that can safely use...
Good catch! Just to make sure I got this right, what happens here is that we register a replacement with a location that does not include the doc comment location,...
I wonder how much of a problem that actually is. Aside from the ambiguity to the user, it does not seem to be particularly harmful. Do you have an example...