Nathan Rebours

Results 218 comments of Nathan Rebours

Yes, sorry for the long delay and thank you for the reminder. I'll add that in the next few days!

The parestree changes issue should be fixed by https://github.com/ocaml/ocaml/pull/13431. I think that even though not all API changes to those modules will be breaking, it's good for ppxlib maintainers to...

From a quick look I think only the change in the `Longident.t` type will impact us. It hadn't changed until now so it is not versioned by ppxlib but that...

I'm closing this as it has been fixed since then!

Circling back to that, would fixing ppxlib's driver to provide a consistent set of flags, regardless of what ppx-es are being linked help toward having a simple variable to store...

I think this patch is causing #450. There's something fishy going on when instrumenting `Pfunction_cases` that can lead to it being converted to a `Pfunction_body` which triggers the compiler invariant...

Opened a PR to @patricoferris' branch here: https://github.com/patricoferris/bisect_ppx/pull/1

The test suite is broken at the moment so I tried to make the minimal set of changes required to make my new regression test work, for anybody willing to...

@AllanBlanchard thanks for the minimization, I confirm I can reproduce the error with it and am working on a fix!