Nathan Rebours
Nathan Rebours
> When you said, "update ppxlib-tools deps to reflect the changes?", what did you mean by that? I didn't get it. Now that ppxlib-tools depends on `yojson`, we need to...
I'm trying to wrap up the 5.3 compat thing and I'll review and merge right after, sorry for the delay!
@pedrobslisboa nice, thanks! I'm trying to wrap up the 5.4 compat with @patricoferris but I'll review this shortly I promise!
Yes it was fixed in `0.31.0`, see the first changelog entry [here](https://github.com/ocaml-ppx/ppxlib/blob/main/CHANGES.md#0310-2023-09-21).
Having a proper comparison function for this and a proper printer would be great yes. I guess the printer is a bit more important in the short term as it...
From a quick look I think it's the other way around, our migrations are bugged in a way that will turn `fun x y -> x + y` into `fun...
I'm closing this as it's been fixed on [`trunk-support`](https://github.com/ocaml-ppx/ppxlib/tree/trunk-support)
I'm closing this since this outreachy round is over!
CC @mbarbin, if you want to test this feature. CC @ceastlund, I'd be curious to know if you get any warnings when enabling this flag for JS' codebase.
Yes this PR is a bit out of date now. Since @mbarbin started working on the right implem, I'd prefer to take his contributions! Let's close this!