Nathan Daly

Results 101 issues of Nathan Daly

Last year, we made several performance improvements to FixedPointDecimals, and a lot of them used `@pure` to enforce constant folding. However, since then (as discussed in last year's JuliaCon talk...

bug
performance

We already support converting a FixedDecimal to a Rational, via: https://github.com/JuliaMath/FixedPointDecimals.jl/blob/e8c9f3b4b68c85fa0bb8813b35c27ee267114175/src/FixedPointDecimals.jl#L324-L326 We should also provide `numerator()` and `denominator()`, as part of that interface. They might be implemented like this: ```julia...

help wanted

However, the simple overload does not seem to work, since it is ambiguous with `rem(x,y,::RoundingMode{Up})`, for example, so for `rem`, we're manually overloading all RoundingModes.

enhancement

Add a custom implementation of `fldmod(x::T,y)` for when `y` is a const, and call it whenever T >= Int128. This improves performance for `*(a::FD{Int64}, b::FD{Int64})`, b/c `*` passes the result...

Opening this PR to discuss merging benchmarks into this repo, so that we can track performance across commits/versions. I'm not sure if there's a usual structure to follow for putting...

Splitting out the benchmark discussion from https://github.com/JuliaMath/FixedPointDecimals.jl/pull/36. ------ Here's the benchmark in a gist: https://gist.github.com/NHDaly/a8fae0d1d65ab1066c585c27e54146fa And the results in a google spreadsheet: https://docs.google.com/spreadsheets/d/1Lc3ughgwwK25cpwbnuLRxw19EtaMxdCsMmtnspT_4H8/edit?usp=sharing ------- Here are the results:   |   |...

To keep in style with the rest of the macros exported by this plugin, can we change `@emit` to `@qmlemit`?: https://github.com/barche/QML.jl/blob/master/src/QML.jl#L119 When I came across that line in your example,...

enhancement

@davidanthoff: We have found that the performance for our large repository is _absurdly_ bad. For example, consider this video, where you can see that it takes about **2 minutes** to...

If you have a test file that has a typo in it, and accidentally looks like this: ``` # src/foo_test.jl @testitem "test 1" begin ... end @testiteem "test 2" begin...

VSCode test running follows this simple rule: for each `@testitem` we look in the folder, then in the parent folder etc until we find a `Project.toml` that defines a package,...