Nathan Daly

Change `MultiDict` to be backed by a `MultiSet` instead of a `Vector`; add `delete!(md, k, v)`

1

This PR builds on top of all the currently open PRs related to MultiDicts, to change the implementation to be built on a `Dict{K, MultiSet{V}}`. This allows logarithmic-time lookup of...

MultiDict: Have `iterate()` iterate over all pairs, as if the dict actually allowed duplicate keys

6

```julia julia> collect(MultiDict(3=>3, 1=>2, 1=>4)) 3-element Array{Pair{Int64,Int64},1}: 3 => 3 1 => 2 1 => 4 ``` Fixes https://github.com/JuliaCollections/DataStructures.jl/issues/655

RFC: Change MultiDict constructors to more closely match the abstraction: accept _multiple pairs_

8

From my understanding, the MultiDict is like a Dict, except that it can hold multiple pairs that have the same key. Much like bag-semantics in SQL. And the current constructors...

Add a delete!(::MultiDict, k, v)?

3

Does it make sense to add a `delete!(::MultiDict, k, v)` function where you can delete a _specific_ `key=>value` pair? Similar to the existing `insert(::MultiDict, k, v)` which inserts a specific...

Shouldn't iterate(::MultiDict) return each pair, like it was inserted?

3

This feels wrong and surprising to me: ```julia julia> d = DataStructures.MultiDict{Int,Int}() MultiDict{Int64,Int64}(Dict{Int64,Array{Int64,1}}()) julia> insert!(d, 1,1) MultiDict{Int64,Int64}(Dict(1 => [1])) julia> insert!(d, 1,2) MultiDict{Int64,Int64}(Dict(1 => [1, 2])) julia> collect(d) 1-element Array{Pair{Int64,Array{Int64,1}},1}:...

Reduce memory & redundant work for concurrent TimeZones construction

6

This commit improves the thread-local caching scheme introduced in #344, by sharing TimeZones across _all_ thread-local caches (so there's only ever one TimeZone object instance created per process), and reduces...

TTF no longer works?

8

Hi! So it seems that for some reason SDL_ttf no longer works... It crashes for me when executing `SDL2.CreateTextureFromSurface(renderer,text)`. I assume for you as well, since you commented out the...

We should ideally copy all the comments from the original `.proto` file into the new generated `_pb.jl` file by reading the comments fields off of the `SourceCodeInfo` proto. An example...

Threading exceptions in Python 2.7

9

Hi, I am running the example code (exactly) provided in the README, and I am intermittently (like, once per 5-10 runs) getting this exception, and then the process stops working:...

https://github.com/JuliaComputing/Azure.jl/blob/a5b64f01d9784904c1008e82ba5c784e6d3831cf/src/rest_api_protocol.jl#L54-L56 This constructor (and probably almost all functions) that takes a `Vector{UInt8}` should really be taking an `AbstractVector{UInt8}`. As it is currently defined, you will get a MethodError if you...