QML.jl icon indicating copy to clipboard operation
QML.jl copied to clipboard

Can we change `@emit` to `@qmlemit`?

Open NHDaly opened this issue 8 years ago • 2 comments

To keep in style with the rest of the macros exported by this plugin, can we change @emit to @qmlemit?: https://github.com/barche/QML.jl/blob/master/src/QML.jl#L119

When I came across that line in your example, I wasn't sure if that was some standard Julia "create an interrupt signal" macro or a QML-specific "signal".


Thanks again for the presentation at JuliaCon! I'm excited by this project! Appreciate your thoughts! ~Nathan

NHDaly avatar Jun 26 '17 14:06 NHDaly

True, that would be more consistent. I did discuss with @shashi about issue #43, so I'm going to take a close look at the Observables package first and see if we can maybe come up with a general signals/slots syntax.

barche avatar Jun 26 '17 14:06 barche

Sure, makes sense. Cool! Thanks!

On Jun 26, 2017 9:28 AM, "Bart Janssens" [email protected] wrote:

True, that would be more consistent. I did discuss with @shashi https://github.com/shashi about issue #43 https://github.com/barche/QML.jl/issues/43, so I'm going to take a close look at the Observables package first and see if we can maybe come up with a general signals/slots syntax.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/barche/QML.jl/issues/44#issuecomment-311075949, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgkEV9zKoSSri34OzN1USzbQFqKoKoqks5sH8AkgaJpZM4OFWw3 .

NHDaly avatar Jun 26 '17 14:06 NHDaly