Nicolas Giard

Results 173 comments of Nicolas Giard

This is a **tags** limit, not commits. All commits will be fetched, whether it's 10 or 1000. 100 is the maximum tags that can be fetched in a single graphQL...

Are your tags valid semver without the prefix? For example, if you set the prefix to `foobar/`, then your tags should be `foobar/1.0.0` or `foobar/v1.0.0`. Using `fromTag` won't do what...

Completely unusable with Cloudflare R2 since this release. How can this be disabled directly in js (without env vars or file settings)?

@trivikr Right but this library doesn't live in a vacuum and is used extensively outside of AWS. This was poorly handled on your part and resulted in a ton of...

Use rebase, your PR contains a ton of unrelated file changes

They did the same thing in the JS client. Leave it to AWS to introduce breaking changes and pretend their library isn't used extensively with other services...

What if the oidc server doesn't have a .well-known endpoint? It should still allows to specify the endpoints manually.

> I actually wasn't fully aware that the discovery endpoint is optional for OIDC. For representing this in the settings, my thought would be to add the well-known URL as...

I moved it to `client/themes/default/scss/app.scss` in 1b6c67ee77b3ad3bf1b2cb3380c2a3eda28aa3f2 to keep it consistent with other print rules. I also changed "word-wrap" with "overflow-wrap" which is the correct standard property to use. See...