Niels Dekker

Looks like this error is caused by a behavior change of `itk.imread`. I tried the following with Python 3.6 (!) and ITK 5.2.1 (without ITKElastix): ```python images = itk.imread("data/00", itk.F)...

> I think the new direction behavior of `itk.imread` is correct. Thanks, but note that even ITK 5.3.0 still had the old behavior (using Python 3.7): ``` >>> images =...

Hmm, DCMTK's dcmdump tells me that the images from [examples/data/00](https://github.com/InsightSoftwareConsortium/ITKElastix/tree/a3b0e5589b7d07c81fdc303a366e7bce327b7297/examples/data/00) have a negative SpacingBetweenSlices. (0018,0088) DS [-2.0] # 4, 1 SpacingBetweenSlices And 00-slice000.dcm has SliceLocation `[115.50]` while 00-slice009.dcm has SliceLocation...

For the record, here is where the direction sign and the spacing sign get flipped: https://github.com/InsightSoftwareConsortium/ITK/blob/b375cefdc7fcd761a5581359e35dfecdc5f9d615/Modules/IO/ImageBase/include/itkImageFileReader.hxx#L222-L235 As originally committed by https://github.com/InsightSoftwareConsortium/ITK/commit/7501479a970694b0dd4a8c4bbf7cbcc033fe059c "ENH: Image spacing must be positive", by [Francois Budin](https://github.com/fbudin69500),...

@mstaring I see now, the check that produced this error message was introduced by this commit: https://github.com/SuperElastix/elastix/commit/e9a02d9938c17f2705d874ac6ce9235cb3368db8, "ENH: add sanity check for direction cosines", 6 Aug 2014. Would it be...

Oh, I see now, the VarianceOverLastDimension metric already filled its GridSize with NumberOfSubTransforms when its registration had a StackTransform, with commit 5fc4bcc2750edab13cdeee55e93ba7552bd8ed32 Coert Metz (@coertmetz), 27 Oct 2010. Even while...

Discussed at the weekly internal elastix sprint. Marius and Stefan agreed that it is not necessary to set the GridSize in these particular cases, so the pull request should be...

For the record, "itkPCAMetric.h" and "itkPCAMetric.hxx" were unused already with their first commit, 764490d5e37de792fea4340fc11850bfd067318d, "Add: Added PCAMetric, PCAMetric2 and SumOfPairwiseCorrelationCoefficientsMetric...", by Wyke (@whuizinga), 24 Nov 2015. Nevertheless, these source files...

Discussed at the weekly internal elastix sprint. Marius and Stefan agreed that it is OK to remove the old "itkPCAMetric" files, and rename the "itkPCAMetric_F_multithreaded" files to "itkPCAMetric".

- For the record, the interesting `if(BUILD_SHARED_LIBS) set(ITKHDF5_LIBRARIES hdf5_cpp-shared...)` appears introduced with pull request #2247 commit df5f96179af5220d080780e4fc31d3de7e23e7b3, by @KrisThielemans, Jan 10, 2021.