Niels Dekker
Niels Dekker
> Should second and third commit be put into a separate PR, meant to be merged? - OK, for VTKPolyDataMeshIO: pull request #5548 The HDF5ImageIO commit ("ENH: Support H5::PredType::NATIVE_SCHAR...") _might_...
/azp run ITK.Linux.Python
/azp run ITK.macOS.Python
> Thinking of how this went on for so long, I realized I never used `DataObjectError`. I guess most code uses `itk::ExceptionObject`. `DataObjectError` is the base class of `InvalidRequestedRegionError`, which...
Is the FastBilateralImageFilter still relevant nowadays? I see, there was a publication of the filter by Jordan Woehr on 2009-08-28, [A Fast Approximation to the Bilateral Filter for ITK](https://insight-journal.org/browse/publication/692). The...
> Niels, it would be good if you tackled these (and possibly other changes) yourself. @dzenanz Sorry, I'm just doing a little bit of reviewing of this PR now. By...
- The first of the two commits (on ConnectedComponent tests) has test failures that I find hard to fix. So I branched off the other one (on Voronoi), which should...
There appeared test failures at https://open.cdash.org/viewTest.php?onlyfailed&buildid=10817138 on the following four tests: 1. itkConnectedComponentImageFilterTest 2. itkConnectedComponentImageFilterTest2 3. itkConnectedComponentImageFilterTest3 4. itkConnectedComponentImageFilterTestRGB I'm sorry, I don't really know how to fix them, but...
@hjmjohnson Please `git rebase main`! I guess your pull request should only have one commit, being the last one, right?
@thewtex Thanks to Matt McCormick for encouraging me to submit this issue!