Adam Thompson-Sharpe

Results 17 comments of Adam Thompson-Sharpe

I'm working on types for color.js right now on DefinitelyTyped/DefinitelyTyped#62510. I prefer DefinitelyTyped for definitions files because I think they have good infrastructure to test and maintain, but I could...

I'll work on moving the types to a PR over here. If maintainers are interested, I'll also try to configure a CI job to test the types with dtslint the...

I just opened #221 to bring the types over from DefinitelyTyped, but I'm having trouble getting TypeScript and dtslint to work properly, at least on my local setup.

> Approved but version 0.4.2 would be better instead of 0.5.0 Agreed, but DefinitelyTyped infra doesn’t let me do that. Oh well 🤷🏻‍♂️

~~I'm not sure whether this change is actually possible to implement (see )~~ Works after 1929f1e52380bfef192ef28da06b186f338dc106

> > It looks like this is your library: https://github.com/youennpj/react-gtm > > > > > > It's probably a better idea to bundle these type definitions there instead of doing...