DefinitelyTyped
DefinitelyTyped copied to clipboard
[cobe] Remove unneeded types
The npm package cobe has bundled its own types since v0.4.2.
v0.4.1: https://unpkg.com/browse/[email protected]/dist/ v0.4.2: https://unpkg.com/browse/[email protected]/dist/
The version specified in notNeededPackages.json
is actually a higher version (0.5.0) to fix CI problems.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change.
- [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
pnpm test <package to test>
.
If removing a declaration:
- [x] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
- [x] Delete the package's directory.
- [x] Add it to
notNeededPackages.json
.
@MysteryBlokHed Thank you for submitting this PR!
This is a live comment which I will keep updated.
This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?
1 package in this PR (and infra files)
Code Reviews
This PR can be merged once it's reviewed by a DT maintainer.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ A DT maintainer needs to approve changes which affect DT infrastructure (
notNeededPackages.json
)
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 68589,
"author": "MysteryBlokHed",
"headCommitOid": "45e4923ff1d961a4e5fa32be55f54a7650f6d9f9",
"mergeBaseOid": "0dbd18bb285f21a3675650f7da4b2443aed323ce",
"lastPushDate": "2024-02-11T06:12:42.000Z",
"lastActivityDate": "2024-02-26T17:59:11.000Z",
"mergeOfferDate": "2024-02-26T17:24:34.000Z",
"mergeRequestDate": "2024-02-26T17:59:11.000Z",
"mergeRequestUser": "MysteryBlokHed",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "cobe",
"kind": "delete",
"files": [
{
"path": "types/cobe/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/cobe/cobe-tests.ts",
"kind": "test"
},
{
"path": "types/cobe/index.d.ts",
"kind": "definition"
},
{
"path": "types/cobe/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/cobe/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"martin-badin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-02-26T17:23:48.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "martin-badin",
"date": "2024-02-22T06:54:21.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1937443853,
"ciResult": "pass"
}
🔔 @martin-badin — please review this PR in the next few days. Be sure to explicitly select Approve
or Request Changes
in the GitHub UI so I know what's going on.
@MysteryBlokHed The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
@MysteryBlokHed The CI build failed! Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!
Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.
Re-ping :
This PR has been out for over a week, yet I haven't seen any reviews.
Could someone please give it some attention? Thanks!
Approved but version 0.4.2 would be better instead of 0.5.0
Agreed, but DefinitelyTyped infra doesn’t let me do that. Oh well 🤷🏻♂️
@MysteryBlokHed: Everything looks good here. I am ready to merge this PR (at 45e4923) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@martin-badin: you can do this too.)
Ready to merge