myo_sim icon indicating copy to clipboard operation
myo_sim copied to clipboard

Adjusting MyoBack model and Full body model

Open cherylwang20 opened this issue 10 months ago • 5 comments

Changes based on comments in this pr: gh pr checkout 37

  1. Change all mesh filenames to lowercase to align with the code standards: https://github.com/MyoHub/myo_sim/pull/38/commits/a730668110c6edb287ea9d3c0db7dcb5ee6ce0ee

  2. Remove meshes/ribcage_s.stl, use thorax.stl: cd6efca

  3. eliminate internal collision of back/myoTorso_exosuit.xml and back/myoTorso.xml models have internal collisions. 078ba0a and ab975b2 image image

  4. Previous keyframe issue - : this is only cause by actively adjusting the abs, which is meant to control passively with joints. I have lower the limit of the abs to decrease extreme behavior: cd6efca

  5. Missing lumbar1, this is a bug based which the geom is not displayed: 6523246. Fixed: image

cherylwang20 avatar Apr 28 '25 07:04 cherylwang20

@vikashplus @Vittorio-Caggiano

cherylwang20 avatar Apr 28 '25 07:04 cherylwang20

Thanks for the review. The latest update includes:

  1. Changed all wrapping objects to the same class of group and color.
  2. Removed redundant wrapping geoms in the chest.
  3. Clean up exo geom classes.

@Vittorio-Caggiano @vikashplus

cherylwang20 avatar May 08 '25 10:05 cherylwang20

image

  1. Abdomen_ellipsoid looks unnecessary. I haven't seen any reference to it anywhere
  2. Rename Cylinder2_cylinder and Cylinder_cylinder with more meaningful names

vikashplus avatar May 12 '25 19:05 vikashplus

better align myoTorso_body_exosuit and myoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models.

I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraints

vikashplus avatar May 12 '25 19:05 vikashplus

There are a lot of sidesite sites that are floating around in free space. image It will be great to add a class for these as well, and move them to a group that is hidden by default

vikashplus avatar May 12 '25 19:05 vikashplus

image 1. `Abdomen_ellipsoid` looks unnecessary. I haven't seen any reference to it anywhere 2. Rename `Cylinder2_cylinder` and `Cylinder_cylinder` with more meaningful names,

remove the abdomen_ellipsoid geom, and rename Cylinder2_cylinder and Cylinder_cylinder to back_cylinder_s and back_cylinder_l accordingly. 1437a9b

cherylwang20 avatar May 18 '25 16:05 cherylwang20

There are a lot of sidesite sites that are floating around in free space. image It will be great to add a class for these as well, and move them to a group that is hidden by default

Created a new class for all sidesite, with group 3. 7ad2e17

cherylwang20 avatar May 18 '25 17:05 cherylwang20

better align myoTorso_body_exosuit and myoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models.

I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraints

Synced the differences here (one joint range difference): 1631984.

Let me know if a new model is still necessary

cherylwang20 avatar May 18 '25 18:05 cherylwang20

better align myoTorso_body_exosuit and myoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models. I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraints

Synced the differences here (one joint range difference): 1631984.

Let me know if a new model is still necessary

i think, it will be best to create the model. Any form of duplication leads to lots of problems down the road to keep things in sync.

vikashplus avatar May 18 '25 19:05 vikashplus

Latest update:

  1. Both myoTorso and myoTorso_exosuit uses default myoTorso_body as main body.
  2. Body meshes are hard to separate when creating a separate file, "exosuit". Directly inserting bodies in the myoTorso_exosuit allows the freedom to define free joints at will.
  3. Merge the assets file with and without the exosuit. The only difference is having three additional mesh geoms and an exomesh class definition.
  4. Change the collision mesh of myofullbody to group 4.

@vikashplus looping back for review

cherylwang20 avatar May 21 '25 14:05 cherylwang20