Adjusting MyoBack model and Full body model
Changes based on comments in this pr: gh pr checkout 37
-
Change all mesh filenames to lowercase to align with the code standards: https://github.com/MyoHub/myo_sim/pull/38/commits/a730668110c6edb287ea9d3c0db7dcb5ee6ce0ee
-
Remove meshes/ribcage_s.stl, use thorax.stl: cd6efca
-
eliminate internal collision of back/myoTorso_exosuit.xml and back/myoTorso.xml models have internal collisions. 078ba0a and ab975b2
-
Previous keyframe issue -
: this is only cause by actively adjusting the abs, which is meant to control passively with joints. I have lower the limit of the abs to decrease extreme behavior: cd6efca -
Missing lumbar1, this is a bug based which the geom is not displayed: 6523246. Fixed:
@vikashplus @Vittorio-Caggiano
Thanks for the review. The latest update includes:
- Changed all wrapping objects to the same class of group and color.
- Removed redundant wrapping geoms in the chest.
- Clean up exo geom classes.
@Vittorio-Caggiano @vikashplus
-
Abdomen_ellipsoidlooks unnecessary. I haven't seen any reference to it anywhere - Rename
Cylinder2_cylinderandCylinder_cylinderwith more meaningful names
better align myoTorso_body_exosuit and myoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models.
I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraints
There are a lot of sidesite sites that are floating around in free space.
It will be great to add a class for these as well, and move them to a group that is hidden by default
1. `Abdomen_ellipsoid` looks unnecessary. I haven't seen any reference to it anywhere 2. Rename `Cylinder2_cylinder` and `Cylinder_cylinder` with more meaningful names,
remove the abdomen_ellipsoid geom, and rename Cylinder2_cylinder and Cylinder_cylinder to back_cylinder_s and back_cylinder_l accordingly. 1437a9b
There are a lot of
sidesitesites that are floating around in free space.It will be great to add a class for these as well, and move them to a group that is hidden by default
Created a new class for all sidesite, with group 3. 7ad2e17
better align
myoTorso_body_exosuitandmyoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models.I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraints
Synced the differences here (one joint range difference): 1631984.
Let me know if a new model is still necessary
better align
myoTorso_body_exosuitandmyoTorso_body. Diff the two files, and you will see that there are multiple conflicting details between the two models. I think the best way to do this is to create a new model, exo_suite, and then add that on top of the existing body using constraintsSynced the differences here (one joint range difference): 1631984.
Let me know if a new model is still necessary
i think, it will be best to create the model. Any form of duplication leads to lots of problems down the road to keep things in sync.
Latest update:
- Both myoTorso and myoTorso_exosuit uses default myoTorso_body as main body.
- Body meshes are hard to separate when creating a separate file, "exosuit". Directly inserting bodies in the myoTorso_exosuit allows the freedom to define free joints at will.
- Merge the assets file with and without the exosuit. The only difference is having three additional mesh geoms and an exomesh class definition.
- Change the collision mesh of myofullbody to group 4.
@vikashplus looping back for review
1. `Abdomen_ellipsoid` looks unnecessary. I haven't seen any reference to it anywhere
2. Rename `Cylinder2_cylinder` and `Cylinder_cylinder` with more meaningful names,
It will be great to add a class for these as well, and move them to a group that is hidden by default