Michael Herzog
Michael Herzog
> e.preventDefault() doesn't seem to work the same way for pointermove as it does for touchmove? After this change, I can trigger the "pull to refresh" gesture on iOS when...
> That said—even if we do get it working perfectly, I really think HTMLMesh should create both pointer* and mouse* events. Especially if it's intended for use outside of this...
https://raw.githack.com/surdu/three.js/trackball-touch-rotate/examples/misc_controls_trackball.html
Do you mind updating `examples/jsm/controls/TrackballControls.js` instead? Files in the `example/js` version are auto-generated.
Your code works like a charm! I just wonder if every user of `TrackballControls` will be happy with this change since the default behavior is now different. Devs _could_ consider...
This is a real nice refactoring! 👍
I have noticed one thing after the approval. Is the use case mentioned in #19430 actually fixed by this PR? It works now if you define a draw range on...
I think I remember now. We've discussed a similar problem in #16950. Instead of using `ShapePath.toShapes()`, do you mind trying the static `SVGLoader.createShapes()` method? It would be interesting to know...
> SVGLoader.createShapes() works well but ShapePath.userData.style.fillRule must be set. Fixed via #24293.
It seems the PR modifies some example files which are unrelated to this change (like `BufferGeometryUtils`, `HTMLMesh` etc.). Even if these modifications are correct, it still clearer to not include...