Michael Herzog
Michael Herzog
> If we dispatch events when the text of a shader changes to tell the renderer that it should update the internal Identifier of the shader text the next time...
> Since I'm not sure if changing shadertext is a common thing. I don't think so. @mrdoob How do you feel about this?
I've forgot `onBeforeCompile()` 🤦. In this case, the hash generation at creation time does not work.
Maybe we don't need such a complex solution, see https://github.com/mrdoob/three.js/issues/24451#issuecomment-1209021806.
TBH, I'm not sure about the PR's complexity....
Just for my understanding: Why is the ray intersection test now done in a different coordinate system?
I can't approve this PR since changing the coordinate system so raycasting happens in world space means each vertex is now converted to world space which ends up in way...
I vote for the initial version.
> three.js supports non-uniform scale (object.scale is a vector3, not a float), so support for non-uniform scale here is expected. I don't think this statement is entirely correct, see https://github.com/mrdoob/three.js/issues/15079#issuecomment-431232639....
I still vote for the initial version of the PR. If we ever get a report about failing raycasting with non-unifrom scale, we can reconsider what you have suggested here:...