Michael Herzog

Results 651 comments of Michael Herzog

BTW: If we decide to use PMREM for background blurriness, we can use (parts of) #20463. I've started to use PMREM since BabylonJS does it the same way.

The example needs to be added to `files.json`. Otherwise it does not appear in the side menu. And please add the respective E2E screenshot via: ``` npm run make-screenshot webgl_shadowmap_manual_update...

> I was taking a look at ColladaLoader and OBJLoader, as well. It doesn't look like there's very explicit documentation on color spaces for these formats and they're more specification...

The left image is right. If you just set `outputEncoding` to `sRGBEncoding`, the sRGB workflow is incomplete.

I wonder if it is really a good idea to force sRGB with 3D formats that do not properly support it 🤔 .

AFAICT, the Collada spec does not really care about color spaces. Most times applications just load the Collada, parse the colors/load textures and display the values as they are. You...

Some progress: a12b117c1d1413434a751adb3571a29836bd2b1c

Just wanted to note that some examples put the asset's license into the HTML file like in: https://threejs.org/examples/webgl_loader_collada I guess we have to decide where to put the licenses and...

I've looked into this issue multiple times but I'm afraid it can only be solved by rewriting major parts of the class. The problem is that certain methods like `calculateRotationAxis()`...