Julien Lebosquain

Results 177 comments of Julien Lebosquain

Public API for review: ```diff namespace Avalonia.Skia { + public enum SurfaceOrientation + { + Normal, + Rotated90, + Rotated180, + Rotated270, + Unknown, + } + public interface ISurfaceOrientation...

Notes from the API review: - Remove `SurfaceOrientation.Unknown`. Internally, a nullable value can be used instead when the orientation is effectively unknown. - Move `SurfaceOrientation` and `ISurfaceOrientation` from the `Avalonia.Skia`...

I don't think that's right, the fallback fonts should be used to determine the line's height as soon as they're used, or we'll get clipping and other issues. They should...

Could you please add a matching unit test so we can validate and avoid regressing the calculation in the future?

We might also consider making all the converters `sealed`. A converter really doesn't need to be open for extensibility.

> I think some applications have both fluent and simple installed, will the linkage cause any conflict? It might. We should probably change the converters' namespace to match the current...

> Still not sure how on Windows 10 this invokes the search window... @StefanKoell I have a hunch that this line is the culprit: https://github.com/AvaloniaUI/Avalonia/blob/14fff9a28fbb6bd5ca9f776cf0e0c24228af8936/tests/Avalonia.IntegrationTests.Appium/PopupsTests.cs#L31 The screen is pretty tiny...

> @MrJul I tried your suggestion - still not working. Right now, I also really can't run the tests locally because my x64 machine isn't available at the moment and...

Only one test is now failing on Windows, `TopMost_Popup_Should_Stay_Above_Other_Windows` so there's definitely progress! I'm not sure why the `ShowTopMostPopup` button couldn't be found in this case...

First of all, thank you for your contribution! I haven't looked at the code at all yet, but there's a bunch of failing tests after this PR: https://dev.azure.com/AvaloniaUI/AvaloniaUI/_build/results?buildId=56039&view=ms.vss-test-web.build-test-results-tab. Some existing...