Julien Lebosquain
Julien Lebosquain
API diff for review: ## Avalonia.Markup.Xaml (net10.0, net8.0) ```diff + namespace Avalonia.Markup.Xaml.Diagnostics + { + public static class VisualDiagnostics + { + public static readonly Avalonia.AttachedProperty SourceInfoProperty; + public static...
Notes from the API review meeting: - We don't want to expose the attached property directly, as we might want to store that information using a `ConditionalWeakTable` or an alternative...
I'm going to close this since the source info part has been extracted to #20220. The previewer and/or dev tools implementation will be done separately.
Notes from the API review meeting: - Mark `IGlyphTypeface` as `NonClientImplementable` - Consider making `TryGetStream` not part of the public API of `IPlatformTypeface` - Make `OpenTypeTag.None/Max/MaxSigned` internal - `IGlyphTypeFace.IGlyphCount` should...
API diff for review: ## Avalonia.Base (net10.0, net8.0) ```diff namespace Avalonia.Media { + public sealed class ColorMatrix + { + public ColorMatrix(double m11, double m12, double m13, double m14, double...
Notes from the API review meeting: - Rename `ColorMatrixFilterEffect` to `ColorMatrixEffect`, matching WinUI and Winforms. - Remove the `CreateTranslation` method (leftover?). - Use `float` instead of `double` here. Values will...
@bombizombi Thank you for your contribution. Before we can review it or give any advice, as mentioned [above](https://github.com/AvaloniaUI/Avalonia/pull/20166#issuecomment-3600800170), you need to merge `master` back into your branch, or alternatively rebase....
Thank you for your contribution! I'll review and test in depth when I have a bit more time, but the first point seems very strange to me. Which OS, architecture...
Note regarding the `ReadOnlySpan`: even in debug mode, I don't see those allocations at all (I was very surprised at the original claim since I remember running dotMemory on debug...
Yes you're right, not sure how I missed that last time, or if I wasn't looking at the right thing, sorry about that. While I still think that keeping things...