Julien Lebosquain

Results 177 comments of Julien Lebosquain

Thank you for adding the new tests. > @MrJul some test are failing, but it seems to be an appium issue (not related to my changes - i guess?) Yes,...

Public API for review: ```diff namespace Avalonia.Input.GestureRecognizers { public class ScrollGestureRecognizer : GestureRecognizer { + public static readonly DirectProperty OffsetProperty; + public static readonly DirectProperty ExtentProperty; + public static readonly...

Notes from the API review: ## Remove the properties added to `ScrollGestureRecognizer` Exposing `Extent`, `Offset` and `Viewport` shouldn't be necessary. We don't want to add every possible scroll info property...

> Because `IScrollable` and `ScrollViewer` are actually defined in Avalonia.Controls which I do not have a reference to. Sorry for the late reply, you're completely right. I'm not sure why...

Notes the from API review meeting: For consistency and because those events are very common ones, we're okay with adding the following virtual methods to `InputElement`: ```csharp InputElement.OnTapped InputElement.OnRightTapped InputElement.OnDoubleTapped...

> Long answer: I'm of the opinion that every class which defines a `RoutedEvent` should also define a virtual handler method for it, unless that would create a performance problem....

Notes from API review: - Make the existing `Flyout.IsOpen` setter public. - Change the property to be a `StyledProperty` for consistency with `Popup.IsOpen`. During the review, it was mentioned that...

Discussion for `Popup.IsOpen`: https://github.com/AvaloniaUI/Avalonia/discussions/19032

Notes from API review: we're fine with exposing this information publicly, but rather as a `CursorRectangle` property directly.

Is it possible to help move this issue forward? The `IMessagePump` [proposed above](https://github.com/nunit/nunit/issues/2917#issuecomment-631210601) looks good enough to me at first glance, but I'm no expert on all the internal layers...