Mr. HeliX
Mr. HeliX
> You would want to remove hidden [here](https://github.com/ppy/osu-tools/blob/3a1d088bdf2e3f31b5970fb8f74c5ab93ac36d2e/PerformanceCalculator/LegacyHelper.cs#L78) then, the code originally intended to only consider hidden a relevant mod if flashlight is enabled > > It'd also potentially make...
Closing this in favour of https://github.com/ppy/osu-tools/pull/216
> Would you mind doing the same for GUI? https://github.com/ppy/osu-tools/blob/master/PerformanceCalculatorGUI/RulesetHelper.cs Not too familiar with the GUI code but I think this does the trick
> ~On Lazer, even with CL it still does the Lazer way of doing hits, therefore you cannot simply check for CL here.~ ~This is a bit troublesome as there's...
> > `generateHitResults` still assumes perfects and greats to generate the same accuracy value but `GetAccuracy` distinguishes the two by either `305` or `300` values. > > The math works...
Thanks, should be all good now
> You've forgot to update hitresult generation for GUI Oops, updated that as well