ppy
Added hidden to relevant mods
Fixes hidden not counted as relevant mods when using simulate command without the -nc parameter
Before:
After:
You would want to remove hidden here then, the code originally intended to only consider hidden a relevant mod if flashlight is enabled
It'd also potentially make sense to make an in-line comment for it, as this method would now differ from the source for this method specified in the comment above
You would want to remove hidden here then, the code originally intended to only consider hidden a relevant mod if flashlight is enabled
It'd also potentially make sense to make an in-line comment for it, as this method would now differ from the source for this method specified in the comment above
Of course yeah, updated PR
I'm not sure this is entirely correct because SR-wise HD only has an effect when combined with FL.
That is, perhaps the following should only be applying this filter to the mods passed to the difficulty calculator, rather than the ScoreInfo:
https://github.com/ppy/osu-tools/blob/a1bb55f1008e9804b740769c139dbec67ac7f4a9/PerformanceCalculator/Simulate/SimulateCommand.cs#L59-L77
As it is, it also means some other mods like TC are filtered out. As for ScoreInfo, the only filtering that needs to happen is:
https://github.com/ppy/osu-queue-score-statistics/blob/e24ca9f582542119e003dc047df5c693ae1a0b59/osu.Server.Queues.ScoreStatisticsProcessor/Processors/ScorePerformanceProcessor.cs#L171-L183
Also, the NoClassicMod is horribly mis-intentioned here - it's being used to filter the mods but really the filtering should be applied by default regardless of that option. There should be two options - --no-classic and, let's say, --no-filter. Or, we can invert and add --classic, I'm fine with either as long as it's agreeable.
This doesn't need to be addressed in this PR, but is something to think about... I'm fine using that option for now.
