Moritz Hübner
Moritz Hübner
LGTM if removing `github.event` doesn't change the behavior The previous state worked as expected already.
> Tried to install the magma package and python3 dependencies on a regular VM per @nstng instructions (as in the PR description): > > * delete `/etc/magma` > > *...
> > Needs a rebase and reviews from @magma/approvers-bazel and @magma/approvers-agw-pipelined . > > FYI: do not try to merge the requirements.txt - please rebuild it after the rebase @nstng...
I triggered a run for the lte integ test https://github.com/MoritzThomasHuebner/magma/actions/runs/2917075867
> The changes look good to me. I verified i could build all `py_binary`s with Bazel, and run the `subscriberdb` binary which uses the new `systemd-python` package. I did not...
My changes, including tests: https://github.com/maxhbr/magma/pull/1
The first test posted above is actually in `reindexer_singleton_test.go`. Upon going through the recent CI runs, the following tests seem to be failing this often: TestSqlConfiguratorStorage_LoadEntities: 2 TestGetSubscriberState: 2 TestSingletonRunSuccess:...
There is still the issue with `clear_orc8r` and some other variables in `lte/gateway/python/integ_tests/federated_tests/fabfile.py`. Those variables are not converted to booleans at the moment.
I ran the extended tests with the most recent fixes, the following extended tests are still failing - `test_attach_detach_flaky_retry_success.py` (flaky, passes sometimes for me) - `test_attach_detach_with_he_policy.py`, `test_attach_detach_rar_tcp_he.py` (These probably need...
@jordanvrtanoski Is this PR still relevant, or can it be closed? I changed the scope so in theory it could be merged with approval.