magma icon indicating copy to clipboard operation
magma copied to clipboard

fix(ci): updated deb build CI job

Open ShubhamTatvamasi opened this issue 2 years ago • 5 comments

Summary

Test Plan

Additional Information

  • [ ] This change is backwards-breaking

ShubhamTatvamasi avatar Aug 11 '22 04:08 ShubhamTatvamasi

Thanks for opening a PR! :100:

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

github-actions[bot] avatar Aug 11 '22 04:08 github-actions[bot]

dp-workflow

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 8196fd0b.

github-actions[bot] avatar Aug 11 '22 04:08 github-actions[bot]

LGTM if removing github.event doesn't change the behavior The previous state worked as expected already.

MoritzThomasHuebner avatar Aug 12 '22 01:08 MoritzThomasHuebner

Why would that be necessary? The job looks totally fine to me.

If we remove github.event code works the same but code looks cleaner.

ShubhamTatvamasi avatar Aug 12 '22 12:08 ShubhamTatvamasi

Hi @Neudrino, I guess you also have to approve this.

ShubhamTatvamasi avatar Aug 13 '22 05:08 ShubhamTatvamasi