magma
magma copied to clipboard
fix(ci): updated deb build CI job
Summary
Test Plan
Additional Information
- [ ] This change is backwards-breaking
Thanks for opening a PR! :100:
- All commits must be signed off. This is enforced by
DCO check
. - All PR titles must follow the semantic commits format. This is enforced by
Semantic PR
.
Howto
- Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
- Checks. All required CI checks must pass before merge.
-
Merge. Once approved and passing CI checks, use the
ready2merge
label to indicate the maintainers can merge your PR.
More info
Please take a moment to read through the Magma project's
- Contributing Conventions for norms around contributed code
If this is your first Magma PR, also consider reading
- Developer Onboarding for onboarding as a new Magma developer
- Development Workflow for guidance on your first pull request
- CI Checks for points of contact for failing or flaky CI checks
- GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack
dp-workflow
0 tests 0 :heavy_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:
Results for commit 8196fd0b.
LGTM if removing github.event
doesn't change the behavior The previous state worked as expected already.
Why would that be necessary? The job looks totally fine to me.
If we remove github.event
code works the same but code looks cleaner.
Hi @Neudrino, I guess you also have to approve this.