Adrian Edwards
Adrian Edwards
> No graceful fallback in config layer > `AugurConfig` unconditionally adds `DatabaseConfig` as a source without checking if the table exists first. I think this is fine to allow the...
> I'm seeing the schema checks fail on bare metal in `main`, so this is likely related to that issue. Can you please share the logs in a new issue...
discussion result: lets do this
@shlokgilda has been thoroughly testing this and has [confirmed](https://chaoss-workspace.slack.com/archives/C0226ELG6R4/p1764789515373849?thread_ts=1764789018.459519&cid=C0226ELG6R4) that the facade workers are flowing and secondary is not memory bottlenecked anymore. I trust this as far as testing goes...
I think I was the one who removed that import because pylint suggested it was unused. I haven't personally tested that change so prob worth reverting just in case.
rebased, fixed the merge conflict with the string fields fix (#3434) and corrected my pylint bug
thanks for this PR! This is also something ive been working on (updating test fixtures to allow a test database to be spun up/set up) One of the challenges is...
> So are you looking forward to work on this issue or should I carry forward with the improvements? I will likely be implementing something very similar to this based...
I dont want to close it because it'll help remind me that i need to get around to doing this. The database test fixture stuff is largely waiting on #3435...
> I just have non-blocking code quality suggestion: use a named constant like `MESSAGE_BATCH_SIZE = 500` instead of a magic number Yep, agreed