Moshe Atlow

Results 23 issues of Moshe Atlow
trafficstars

Reference: https://github.com/nodejs/node/pull/43133#issuecomment-1208494843

assert
needs-ci
commit-queue-squash

this is a proposal to add to `node:assert` a new class assisting with snapshot assertion (e.g compare a values with a snapshot saved to a file (/any other WritableStream)) as...

assert
needs-ci
commit-queue-squash

fixes https://github.com/nodejs/node/issues/40817 awaiting merge of https://github.com/nodejs/node-core-utils/pull/642

meta
tools

refs: https://github.com/nodejs/node/issues/40817 refs: https://github.com/nodejs/node/issues/42125 I was able to test most of the flow except for the actual resume part - since my user dose not have resume permissions , but...

Fixes: https://github.com/nodejs/node/issues/44735 after the previous fix, `spawnWithRestarts` restarts a minimal amount of restarts but continues updating watched file until the test complets

test
needs-ci

I started investigating https://github.com/nodejs/node/issues/44805 when taking a look at https://github.com/nodejs/reliability/issues/388: | Reason | sequential/test-watch-mode-inspect | | - | :- | | Type | JS_TEST_FAILURE | | Failed PR | 9...

a followup for https://github.com/nodejs/node/pull/47499 this includes a lean implementation of https://github.com/isaacs/node-glob on top of minimatch (added at https://github.com/nodejs/node/pull/47499) TODO: - [x] make one or more commits that are not semver-major,...

semver-major
lib / src
notable-change
author ready
needs-ci
commit-queue-failed
commit-queue-rebase
test_runner

Both TypeScript and Bable already support `using` ([explicit resource management proposal](https://github.com/tc39/proposal-explicit-resource-management)), adding this to node will be convenient Co-authored-by: Benjamin Gruenbaum

lib / src
author ready
needs-ci
commit-queue-squash

Fixes: https://github.com/nodejs/node/issues/51548 this PR is still missing tests & documentation

semver-minor
lib / src
notable-change
needs-ci
test_runner