node icon indicating copy to clipboard operation
node copied to clipboard

assert: add `getCalls` and `reset` to callTracker

Open MoLow opened this issue 2 years ago • 1 comments

Reference: https://github.com/nodejs/node/pull/43133#issuecomment-1208494843

MoLow avatar Aug 09 '22 16:08 MoLow

CC @nodejs/assert

MoLow avatar Aug 09 '22 16:08 MoLow

LGTM - I loved the abstractions and how it's designed

I'm just waiting for green CI, it seems some test has broken there

ErickWendel avatar Aug 10 '22 12:08 ErickWendel

CI: https://ci.nodejs.org/job/node-test-pull-request/45971/

nodejs-github-bot avatar Aug 10 '22 13:08 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/44191
✔  Done loading data for nodejs/node/pull/44191
----------------------------------- PR info ------------------------------------
Title      assert: add `getCalls` and `reset` to callTracker (#44191)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:assert-get-calls-reset -> nodejs:main
Labels     assert, author ready, needs-ci
Commits    1
 - assert: add `getCalls` and `reset` to callTracker
Committers 1
 - Moshe Atlow 
PR-URL: https://github.com/nodejs/node/pull/44191
Reviewed-By: Erick Wendel 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44191
Reviewed-By: Erick Wendel 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 09 Aug 2022 16:58:14 GMT
   ✔  Approvals: 2
   ✔  - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/44191#pullrequestreview-1068431589
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/44191#pullrequestreview-1069670520
   ✖  This PR needs to wait 3 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-10T13:37:30Z: https://ci.nodejs.org/job/node-test-pull-request/45971/
- Querying data for job/node-test-pull-request/45971/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2839996187

nodejs-github-bot avatar Aug 11 '22 13:08 nodejs-github-bot

Landed in 74c2c8e08061c9db27606dc52ad540f7fb5a4074

nodejs-github-bot avatar Aug 11 '22 19:08 nodejs-github-bot