Maxim Muzafarov
Maxim Muzafarov
@zstan @anton-vinogradov @isapego @ptupitsyn @NSAmelchev Folks, I've fixed all your comments. Please, take a final look.
Example, ``` # HELP ignite_18b4aac2_metastorememplc_pages Ignite durable memory pages currently loaded in RAM # TYPE ignite_18b4aac2_metastorememplc_pages gauge ignite_18b4aac2_metastorememplc_pages{attr="DirtyPages",} 0.0 ignite_18b4aac2_metastorememplc_pages{attr="PhysicalMemoryPages",} 0.0 ignite_18b4aac2_metastorememplc_pages{attr="TotalAllocatedPages",} 0.0 ignite_18b4aac2_metastorememplc_pages{attr="AllocationRate",} 0.0 ignite_18b4aac2_metastorememplc_pages{attr="CheckpointBufferPages",} 0.0 # HELP ignite_18b4aac2_cacheclustermetricsmxbeanimpl_test_cache_operations_total...
@brian-brazil I've updated metrics according to [Metric and label naming](https://prometheus.io/docs/practices/naming/) and [Instrumentation](https://prometheus.io/docs/practices/instrumentation/) articles. Also, I've updated the metric description (some of them disabled by default).
@brian-brazil yes, I'll update PR shortly.
@smiklosovic Thank you for the comments. Do you agree with the proposed solution design? Do you have any comments on that?
Can we also add a benchmark that emulates rescaling during updates? e.g. `LatencyTrackingBench`
We should update the `.build/README.md` as we've removed `dtest-offheap` and added `dtest-latest`. It's worth mentioning `build-jars.sh` as well.
@belliottsmith I've addressed your comments, please, take a look again :-)
@belliottsmith Hi Benedict, have you had a chance to look at the comments that have been fixed? :-)
@belliottsmith Hi Benedict, I think we are really close to fixing it! :-) Would you mind taking one last look?