cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

CASSANDRA-15254 Support updates on the virtuabl table SettingsTable (use annotations for property updates validation)

Open Mmuzaf opened this issue 1 year ago • 3 comments

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

Mmuzaf avatar May 14 '23 15:05 Mmuzaf

@smiklosovic Thank you for the comments. Do you agree with the proposed solution design? Do you have any comments on that?

Mmuzaf avatar Jul 03 '23 18:07 Mmuzaf

@Mmuzaf I think you did a good job and David already saw it too so ... I may go through it next days again but seems robust enough to me! It would be nice to have yet another pair of eyes on this, if you happen to get somebody to take a look, that would be great!

smiklosovic avatar Jul 03 '23 19:07 smiklosovic

Sorry, been away from this patch for a very long time. If 2 committers are +1 to this patch please don't wait for me and feel free to merge. I don't know when I will have time to review again.

dcapwell avatar Sep 12 '23 18:09 dcapwell