Antonin Décimo
Antonin Décimo
> Maybe we should do the work of writing down the interface of both files, what they expect from the other file and what they provide? I'll give it a...
Thanks for the reviews! I've moved the declaration of the functions in `st_subs.c` and used a forward declaration of `st_masterlock`. I think the code is a bit clearer this way,...
> > I don't have a better idea on how to improve on that. > > Have you considered the suggestion I made [earlier](https://github.com/ocaml/ocaml/pull/13352#issuecomment-2299316030)? It was as follows: > >...
I believe I've addressed all the comments.
If `CAMLprim` is no longer a co-op, should we inspect internal (and possibly external) code for missing or wrong usage of `CAMLprim`?
Thanks for all the detailed explanations. This is looking good, I have two questions: 1. Should the signal and wait code (basically, `threads_posix.h`) stay in systhreads? They're not required by...
I agree with this, and it was my initial design, but @dustanddreams [had noted](https://github.com/ocaml/ocaml/pull/13242#discussion_r1642736766): > I'd rather see this defined as [`assert` instead of `abort`] so that, should it ever...
Could you consider rebasing this on top of your recent changes to #12410?
The idea was to use WinGet to install other things in the future, and to make sure we have one default package manager for Windows things. I'm not surprised that...
IIRC I needed to build WinGet to disable its telemetry, but it can now be disabled via [its settings](https://learn.microsoft.com/en-us/windows/package-manager/winget/settings#disable).