Andrew Misplon

Results 77 comments of Andrew Misplon

@AlexGStapleton Do you perhaps want to send me a build for this PR? My last test above didn't seem to be functioning properly. I was using a build.

Thanks, mate. The base functionality is working. Can you confirm the filter is working for you? ``` add_filter( 'siteorigin_widgets_contact_scrollto_offset', function( $offset ) { return 200; } ); ```

Thanks, mate. - If you don't enter a Button Title, are you able to exit the widget? I don't seem to be able to exit/close the widget. - Should we...

@AlexGStapleton Please check: - SO Widget Block in Block Editor: `ReferenceError: validationSetup is not defined` - Button Widget in Block Widget Interface. Check if working, doesn't seem to for me....

> That's intentional. With this change, and a field being set to required, the user must enter Button Text. If they were able to close the widget, the field isn't...

> With that said, there may be better ways to communicate this - maybe click update, display notice, and then allow update regardless of value. Sounds good. > You can...

I'm trying to think of another way to handle exiting without saving with a required field not filled in. I think your suggestion is the way to go. Thanks!

I originally commented in [Slack](https://siteorigin.slack.com/archives/D0MGRNNTA/p1665995771453879). I'll comment here to clean up our Slack chat. We could offer full validation if there were a way of exiting a widget and leaving...

Thanks, mate. - Are you encountering an error when inserting a SiteOrigin Widget Block with this branch as a build? This block has encountered an error and cannot be previewed....

**- Block Widget Area:** - Legacy Widget: The SiteOrigin Button Widget doesn't have a Save button in this area. - SiteOrigin Widget Block: Same error as the Block Editor.