Michaela Robosova
Michaela Robosova
@vtushar06 - Stubs that you added because of `data-testid` are not needed - just add test ID on actual components. Not that it'd be wrong, but it will be simpler...
Hi @vtushar06, thank you. As for the structure of components, and very high-level, looks as expected :+1: Before we dive into full review though, let's revisit approach to testing. This...
Hi @vtushar06, We will assign reviewer here week or two later, some time after we've merged few other PRs, one of them yours, that will be good to have in...
> One more thing when I tested this in 'rtl' I can see that notranslate class doesn't follow that on official website and same on localhost, what should I do...
Hi @vtushar06, I wanted to mention that I've just merged another PR that introduces `StudioChip` and I think it'd be best to re-use the existing implementation rather than having two...
Much appreciated @vtushar06 - and take all the time you need, no rush. We need to finish other reviews at first anyway.
@vtushar06, before you revisit it, would you also merge the latest `unstable` here and resolved conflicts? Hopefully it will be straightforward - I think the conflicting lines come from the...
Hi @vtushar06, I'm sorry for delay - I will review after I'm back from my vacation. It'll be quite a long time - just in case you wouldn't be around...
Thanks for your patience @vtushar06. Take care and see you in the new year :)!
Hi @GarvitSinghal47, is this ready for re-review?