studio icon indicating copy to clipboard operation
studio copied to clipboard

fix: trash page sorting and show more

Open GarvitSinghal47 opened this issue 9 months ago • 2 comments

Fix #4850

Summary

In this PR, I have updated the load children functionality to accept an ordering parameter, defaulting to lft. Additionally, the "show more" issue mentioned in #4851 is temporarily resolved by hiding the button if no new data is loaded after clicking it. I will investigate further and provide a comprehensive PR explaining why the network request sends data after all nodes have been loaded and resolve it in another pr seperately.

https://github.com/user-attachments/assets/88cd8fbc-eb2e-4148-a80f-0010e731fb63

References

Reviewer guidance

GarvitSinghal47 avatar Mar 23 '25 08:03 GarvitSinghal47

Hi @GarvitSinghal47, is this ready for re-review?

MisRob avatar Apr 30 '25 06:04 MisRob

Hi @GarvitSinghal47, is this ready for re-review?

Yes just waiting for reply on this if confirmed i will remove it otherwise we can keep it as it is as well. Screenshot (11)

GarvitSinghal47 avatar Apr 30 '25 15:04 GarvitSinghal47