Michaela Robosova
Michaela Robosova
To sum up our co-hack: - Applying current calculations on `KIcon` is not as straightforward as I expected - @ozer550 will explore if his flex approach can be adjusted so...
Hi @ozer550, overall looking good, and I like the way it's simpler now. I previewed both compact and non-compact mode and haven't noticed any regressions. Nice work. Just two clarifications.
For use-cases like this, breakpoint based approaches, whether hardcoded or dynamic, will always be a bit cumbersome. It may be best to just detect space available in the toolbar. [`KListWithOverflow`...
Hi @WinnyChang, good to see you around and thanks a lot :) I will review documentation. For the feature itself, we will assign a reviewer next week.
> this change was not intended to be a breaking change, i.e,. KDS consumers should not need to migrate all existing checkboxes to the new v-model api after this change...
Just leaving a note that I skimmed quickly through the updated documentation and it felt clear to me, and as balanced amount of information. Very nice work, thank you.
Thanks @WinnyChang - we will re-review. We have more internal commitments this and next week so it may take longer than usual.
Thank you @WinnyChang and thank you @AlexVelezLl :)
@you-think-you-know-me also please study carefully and follow [the Writing guidelines](https://design-system.learningequality.org/writing). Thank you.
Unassigning @Bindu2020324 as per https://github.com/learningequality/kolibri-design-system/pull/992#issuecomment-2804107561