studio icon indicating copy to clipboard operation
studio copied to clipboard
verified publisher icon learningequality

Fix double wrapped thumbnail icon

Open ozer550 opened this issue 5 months ago • 4 comments

Summary

  • Fix regressions after removing the SVG wrapper around KIcons.
  • Add utility component to support contentKindIcon functionality.

References

closes #4991

Reviewer guidance

  • We would want to regression test Thumbnail component and see if things do not break.

ozer550 avatar Jun 25 '25 06:06 ozer550

@ozer550 I wanted to note that @akolson made some fixes to svg scaling here. It'd be probably best to wait until we merge that and then rebase this PR before we proceed with further refactors.

MisRob avatar Jul 01 '25 13:07 MisRob

https://github.com/learningequality/studio/pull/5147 has now been merged, so can rebase here.

rtibbles avatar Jul 10 '25 23:07 rtibbles

To sum up our co-hack:

  • Applying current calculations on KIcon is not as straightforward as I expected
  • @ozer550 will explore if his flex approach can be adjusted so visually there's no regressions
  • If we have trouble with that, together we will think if there are ways to adjust KIcon to allow for easier scaling

MisRob avatar Jul 28 '25 19:07 MisRob

Hi @ozer550, overall looking good, and I like the way it's simpler now. I previewed both compact and non-compact mode and haven't noticed any regressions. Nice work. Just two clarifications.

MisRob avatar Aug 27 '25 14:08 MisRob