Michaela Robosova
Michaela Robosova
@thesujai I am looping in @nucleogenesis here, since you mentioned you've already had some discussions regarding this together
Linking https://github.com/learningequality/kolibri/pull/13131
Thank you, @lokesh-sagi125. Is this ready for review? If so, would you please fill in the PR description and also linked the issue this is resolving? It will help reviewers.
Note related KDS PR https://github.com/learningequality/kolibri-design-system/pull/799. This PR can be merged after a new KDS release with that change is installed in Kolibri.
I am not entirely sure why would the automatic lint affect another files [in this commit](https://github.com/learningequality/kolibri/pull/12718/commits/4e15663d3002ea1b898c3254ceceacd0a49eeeaf), but perhaps it's not an issue. @rtibbles may have an idea perhaps.
Thanks for getting the PR description ready @lokesh-sagi125. I think this can be reviewed cc @akolson @nucleogenesis @LianaHarris360.
Thanks @muditchoudhary! For QA, test instructions are written here https://github.com/learningequality/kolibri/pull/12243
@radinamatic @pcenov Could you please re-test this PR? I've tried briefly and looked good to me.
Actually we will need one more code adjustment, so let's wait for final version before QA. I will let you know when it's ready @radinamatic @pcenov
Thanks for getting everything ready here @muditchoudhary! @radinamatic @pcenov it's ready for final QA :)