kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

[DO NOT MERGE] Remove FocusTrap in favor of KFocusTrap

Open lokesh-sagi125 opened this issue 1 year ago • 5 comments

Summary

I removed all instances of ' FocusTrap ' that were wrapping ' KModal ', as the focus trapping logic is now handled internally within the KModal component. Additionally, I renamed all remaining FocusTrap instances to KFocusTrap, and finally, I deleted the FocusTrap.vue file since it is no longer necessary. These updates ensure focus trapping is handled consistently throughout the system without causing any regressions.

References

  • #12588
  • https://github.com/learningequality/kolibri-design-system/pull/799

lokesh-sagi125 avatar Oct 14 '24 05:10 lokesh-sagi125

Thank you, @lokesh-sagi125. Is this ready for review? If so, would you please fill in the PR description and also linked the issue this is resolving? It will help reviewers.

MisRob avatar Oct 14 '24 08:10 MisRob

Note related KDS PR https://github.com/learningequality/kolibri-design-system/pull/799. This PR can be merged after a new KDS release with that change is installed in Kolibri.

MisRob avatar Oct 14 '24 09:10 MisRob

I am not entirely sure why would the automatic lint affect another files in this commit, but perhaps it's not an issue. @rtibbles may have an idea perhaps.

MisRob avatar Oct 16 '24 07:10 MisRob

Thanks for getting the PR description ready @lokesh-sagi125. I think this can be reviewed cc @akolson @nucleogenesis @LianaHarris360.

MisRob avatar Oct 16 '24 07:10 MisRob

Hey @lokesh-sagi125! We just released the changes made in https://github.com/learningequality/kolibri-design-system/pull/799, and updated the KDS version in develop with the new release. You can now rebase this PR on top of develop, and run yarn install to fetch the new KDS version :hugs:

AlexVelezLl avatar Oct 30 '24 13:10 AlexVelezLl

yes @AlexVelezLl will do.

lokesh-sagi125 avatar Oct 31 '24 18:10 lokesh-sagi125