Mingun
Mingun
Rebased on top of #310 (which includes #309) and test set updated to have enums in value instances. With this PR errors reported correctly, but strangely only the one (for...
An idea: introduce new `translateMethod(expr)` helper method to do `translate(expr, METHOD_PRECEDENCE)`. I seems that will be more readable.
@dtolnay, @oli-obk, could you look at this simple change? If it's unclear, the `_serde` token is introduced in `wrap_in_const` call few lines below here: https://github.com/serde-rs/serde/blob/7b7e089b8d2f1e42dbb426ebf4f3a35ad72b5beb/serde_derive/src/de.rs#L64-L68
This is fixed currently. In devel IDE: ```yaml meta: id: issue694 instances: value: value: unknown ``` ``` (main): /instances/value/value: error: unable to access 'unknown' in issue694 context ```
I don't understand what JavaScript has to do with it. Isn't SnakeYAML used for parsing? String on input -> compiler parses using it's own understanding of YAML rules? As you...
Is it needed to keep special handling for JS at all? It's 2024, [Map](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map) is widely available: > This feature is well established and works across many devices and browser...
For the reference: there is also one .ksy with underscores in numbers, which should be prohibited in YAML 1.2 (which is js-yaml implements), but it allows them [right now](https://github.com/nodeca/js-yaml/issues/627): https://github.com/kaitai-io/kaitai_struct_formats/blob/e533644618670a3b94be687253b0bf11a051640c/game/renderware_binary_stream.ksy#L419-L434
> Or let's clearly indicate that this issue only reports missing type checks on `if` in value instances so that it can be closed once the [`expr_field_unknown_if_inst_value`](https://github.com/kaitai-io/kaitai_struct_tests/blob/0427d48a0da213241f75f7029cd08217d0e1c7ef/formats_err/expr_field_unknown_if_inst_value.ksy) test passes. Yes,...
Huh? > Below the comparison between parse instance and value instance. There are many other problems with variables, but in this issue **lets focus on missing checks of expression type**:...
Actually, `if` in _value_ instances should be prohibited. I do not see any real usage for it. For the ```yaml meta: id: issue1129 instances: me: value: 1 if: _ ```...