Mingun
Mingun
What specific methods you mean? If you want to figure out which tests covers methods, just add panic in them and see what tests failed. Then you can examine those...
As I say, you can just insert `panic!();` here and see that there is no tests for this method: https://github.com/serde-rs/serde/blob/a685dcf6801884fb7dc638faf95f093d0e1943ec/serde/src/private/de.rs#L528-L535 Because error message say us that this error is expected...
The what is you need is to have a DOM element. I started investigating this in my [dom](https://github.com/Mingun/quick-xml/tree/dom) branch (it is outdated, but I have rebased version on my home...
In #383 author describes exactly this use case and said that it works.
#1448 introduces `#[serde(tag="...")]` on structs. Your needs can be addressed with that code: ```rust #[derive(Debug, Deserialize, Serialize)] #[serde(tag = "method", rename = "Target.setDiscoverTargets")] struct TargetSetDiscoverTargets { id: String, params: TargetSetDiscoverTargetsParams,...
What the advantage of using `#[serde(validator)]` over `#[serde(validate = "...")]`? It seems to me that this is unnecessary introduction of implicit dependency. Because Rust already supports using paths in attributes,...
Probably the problem lies in those lines, because I do not see any other differences between values instances and `seq` fields: https://github.com/kaitai-io/kaitai_struct_compiler/blob/542b24124a95f5308df625d667f8776dd023c696/shared/src/main/scala/io/kaitai/struct/precompile/ResolveTypes.scala#L26-L35 For values instances `ResolveTypes` pass are never run,...
It seems that the real problem is here: ``` EnumById(identifier(my_enum::foo),... ``` Somehow the enum name contains the full name together with type (`my_enum::foo`) instead of just `foo`
Of course... https://github.com/kaitai-io/kaitai_struct_compiler/blob/542b24124a95f5308df625d667f8776dd023c696/shared/src/main/scala/io/kaitai/struct/format/InstanceSpec.scala#L59-L65 another cutting of corners....
@dtolnay, @oli-obk, could you look at this simple optimization?