Mingun

Results 397 comments of Mingun

@GreyCat, @generalmimon, I see that you have some activity in the project recently. Could you find a time to review my PRs, for example, this?

@GreyCat, @generalmimon, I see that you have some activity in the project recently. Could you find a time to review my PRs, for example, this?

@GreyCat, @generalmimon, I see that you have some activity in the project recently. Could you find a time to review my PRs, for example, this?

@GreyCat, @generalmimon, I see that you have some activity in the project recently. Could you find a time to review my PRs, for example, this?

Maybe it is possible to inform npm that `pegjs` dependency is abandoned and users should switch to `peggyjs`?

Just allow to call `to_s` on custom types is not possible, because `.to_s` means access to `to_s` field/instance of an object. Some other syntax is required to calling `to_s`, probably...

> Shouldn't the `xml` namespace be definitionally mapped to `http://www.w3.org/XML/1998/namespace`? Yes, it should. > It also looks like the `xml` namespace should not be overrideable. It seems that override it...

1. Agreed, please make a PR 2. I think we should check other popular XML libraries, and do in the similar way

> Is there a way to mark a field as attribute without modifying its name? Unfortunately, no. You still can solve this problem partially. You can use `#[serde(alias = "...")]`...

No, intermediate serializer should be used with other format serializers. The quick-xml `Serializer` should be used directly