Syine Mineta

Old modpacks may not use Java 17. https://github.com/FTBTeam/FTB-App/blob/86d919d5e912e15683e89c82186a6e93700d4261/subprocess/src/main/java/net/creeperhost/creeperlauncher/pack/InstanceLauncher.java#L455-L468 It will be better to add `MOJANG_DEFAULT_ARGS` flags before adding `jvmArgs` so that end users can override these flags.

Stockfish is a UCI chess engine. I don't see there are major reasons to introduce shared-library-compatible features. People can fork the repository and do their stuffs individually, and I believe...

We use `type(expr)` format for primitive type castings. `static_cast` seems not necessary.

Could you show me what the warning message is? We are already using such convention across the entire source code.

Ok, so this is not a problem of the syntax but rather a compiler issue (MSVC). The first snippet of code converts `uint64_t` to `uint32_t` implicitly, and the second one...

If there are newly introduced instructions or library functions in ARMv9, we can add arm_version = 9 for sure. I believe arm_version = 8 should decently work for ARMv9 as...

> For example, I don't like the fact, that some temporary buffers are created and then they are written with `sprintf` and then streamed into a `stringstream`. First, creating temporary...

> No, if the buffer is too small or a string not null-terminated, you'll get an access violation. ``` char buffer[3][8]; std::memset(buffer, '\0', sizeof(buffer)); ``` Have you checked the previous...

> Hi, the description/commit message does not explain anything about what is the issue of the current code, neither from technical POV or from a user POV. Well, I thought...

I've been running a short test (20+0.2, nodestime=300), you can see there is a difference. ``` LLR: 0.149, LOS: 84.42%, Elo: 6.318 +/- 12.247 / W: 214 L: 200 D:...