FTB-App icon indicating copy to clipboard operation
FTB-App copied to clipboard

Remove hardcoded default parameter G1GC

Open pucgenie opened this issue 1 year ago • 2 comments

Fixes #684 . G1 garbage collector is Java 17's default. Doesn't fix hardcoded vanilla-copied parameter handling.

pucgenie avatar Dec 28 '23 13:12 pucgenie

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 28 '23 13:12 CLAassistant

Old modpacks may not use Java 17.

https://github.com/FTBTeam/FTB-App/blob/86d919d5e912e15683e89c82186a6e93700d4261/subprocess/src/main/java/net/creeperhost/creeperlauncher/pack/InstanceLauncher.java#L455-L468

It will be better to add MOJANG_DEFAULT_ARGS flags before adding jvmArgs so that end users can override these flags.

MinetaS avatar Apr 18 '24 09:04 MinetaS