Milvintsiss comments

Results 7 comments of


                                            Milvintsiss

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID

> @Milvintsiss Thanks for sending this PR. ~Although this documentation is good to have, we probably also~ ~want to update the code to make the clientId programmatically configurable from a...

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID

> I see, I got confused with these 2 IDs. Yes I don't see why it should not be programmatically configurable. And we should update the documentation about saying the...

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID

@cyanglaz Yes it would be great :+1:

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID

@Hixie I think we can close this one, the author has already added [documentation in the README](https://github.com/flutter/plugins/pull/5250/files#diff-bf92ca71f8218dd127d2ce164f12886d20fe34377a6267210f6cd2cd01739c31). Maybe we can add a note about configuring the `SERVER_CLIENT_ID` in the `GoogleService-Info.plist`,...

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID

Hey @cyanglaz can I have a review on this? :)

[google_sign_in_android] Corrects typo in logs

> We _could_ test this. > > More importantly, shouldn't we not be printing those logs anyway? https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#only-log-actionable-messages-to-the-console It could be made more helpful (e.g. explaining what line of code...

Bundling assets only on a specific platform (and remove assets on another platform)

another use case is when you bundle native libs with your app (eg. I use sqlite3 lib on windows and linux, on windows I only need the .dll file and...