Michael Smith

Results 78 comments of Michael Smith

I have gotten Wash working under WSL 2. That doesn't mean native support isn't going to happen, but it is a means to try it out.

We discussed this a bit more. There are a couple things going on here that are useful context, although it's probably fine still to remove this code. Wash's `list` and...

This seems pretty straight-forward. https://github.com/puppetlabs/wash/blob/0.9.0/plugin/aws/ec2Instance.go#L262-L269 handles selecting what connection information to use. If there's no public IP address/DNS hostname we could fall back to private IP address. Making it configurable...

I think in my conversation with folks this was explicitly do `wash exec` on the target. But `exec` also makes sense. So we'll probably need a distinction between them.

That's a great idea, I like it. I'm going to mull it over for a bit, but I don't see any way that contradicts how exec might evolve in the...

I definitely won't get to it immediately, so that would be great. I'd suggest starting by taking a look at https://github.com/puppetlabs/wash/blob/master/CORE_PLUGIN_DEVELOPMENT.md. The Docker plugin includes its view of the filesystem...

I was thinking it'd be something like prepending `cd && `, but maybe that wouldn't be sufficient. It does seem likely that plugins might have different ways to determine the...

Nice work! The `volume` plugin can also be used by external plugins. That's why I suggest having an option to enable this mode in `volume.NewFS`, so we can incrementally add...

Should do https://github.com/puppetlabs/wash/issues/675 first.

Initial thought (from Enis): plugin interface is an entry configuration struct (JSON object for external plugins) that can have configuration. File creation with file content will be a special case...