Miguel Company
Miguel Company
The distance between two parameter IDs should be a multiple of four. It seems Wireshark is not taking into account the alignment rule that the DDS-XTypes 1.3 standard mandates. 
> NIT: In the description clarify that it only affects to operations annotated with `@feed` in the result The fact that we are only going to use it for `@feed`...
@fujitatomoya Thanks for the review. Is it possible to run CI? @clalancette I don't know whether a review from a maintainer is also necessary.
@fujitatomoya @clalancette Now that https://github.com/eProsima/Fast-DDS/pull/5032 has been merged, I have rebased this one and tests should pass. Setting Fast-DDS to 2.14.x would let us detect failures in ROS 2 sooner.
@clalancette The CI here looks good to me. We have just released fastrtps v2.14.3 (see distro PR [here](https://github.com/ros/rosdistro/pull/42060))
@clalancette Friendly ping. https://github.com/ros/rosdistro/pull/42060 has been merged
@clalancette Thanks! Do you think this can be backported to jazzy?
@fujitatomoya Thanks for opening this PR. Don't worry about the linter, it is failing in lines you didn't change. It would be nice if you could add a regression test...
You can check the documentation for the supported annotations [here](https://fast-dds.docs.eprosima.com/en/latest/fastddsgen/dataTypes/dataTypes.html#annotations)