Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[23365] Add `has_more_replies` to `WriteParams` and `SampleInfo`

Open MiguelCompany opened this issue 6 months ago • 1 comments

Description

This PR allows indicating in @feed annotated operations that a reply is not the last one in the feed.

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • [ ] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [x] Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [x] Changes are API compatible.
  • [ ] New feature has been added to the versions.md file (if applicable).
  • [ ] New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [ ] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • [x] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

MiguelCompany avatar Jun 23 '25 10:06 MiguelCompany

Implementation LGTM Tests, doc and versions pending.

NIT: In the description clarify that it only affects to operations annotated with @feed in the result

Mario-DL avatar Jun 26 '25 13:06 Mario-DL

NIT: In the description clarify that it only affects to operations annotated with @feed in the result

The fact that we are only going to use it for @feed RPC operations does not mean that it cannot be used for something else.

MiguelCompany avatar Jun 30 '25 14:06 MiguelCompany