Miguel Company comments

Results 365 comments of


                                            Miguel Company

WIP: Support of statistics with static discovery [12473]

@richiware This needs a rebase

Erroneous "Writer xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx|x.x.x.x not found." [13698]

This was fixed by #2661 and its corresponding backports

Service callbacks not being called after creating multiple service clients

@Barry-Xu-2018 I will check the PRs pending backporting, and report back here

Include the right header when building for iOS

@richiprosima Please test this

Include the right header when building for iOS

@mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

Deadlock in v2.6.2

Closing based on https://github.com/eProsima/Fast-DDS/issues/2961#issuecomment-1292271447

[15766] Update shared_mutex thirdparty to don't prioritize writers

@mergifyio backport 2.7.x 2.6.x

Added tampered buffer deserialization tests

@eboasson FYI, it seems there is an issue on `rmw_cyclonedds` with the deserialization of corrupted buffers.

Connect/Disconnect notification/callback support on publisher

This would be a nice addition, probably as a new `rmw_event_t` as @ivanpauno suggests. We could interpret it as having an event notifying of changes on `get_subscription_count()` We could do...

Connect/Disconnect notification/callback support on publisher

> We should remove `rmw_implementation` in change list since the rmw interface isn't changed in #331 @Barry-Xu-2018 I don't think so, since that repository is there the [tests](https://github.com/ros2/rmw_implementation/tree/rolling/test_rmw_implementation) for this...