Michaël De Boey

Results 420 comments of Michaël De Boey

@m-shojaei Could you please sign the CLA? Otherwise we can't merge this one.

@redabacha Could you please rebase your branch onto latest `dev` & resolve conflicts?

@jacob-ebey Shouldn't we include `fetcher.load` & `fetcher.submit` into the dependencies array instead? 🤔

@huw Do you mean something like @ekosz is doing in #1207?

@axel-xitaso What about getting the tenant info in the `loader` of the `root`? That way you would have it available too without needing this PR.

@axel-habermaier Could you please rebase onto latest `dev` & resolve conflicts?

@mjackson We should probably also add `createWorkersKVSessionStorage` to `packageExports.ts` in both `replace-remix-imports` migration & `eslint-config` https://github.com/remix-run/remix/blob/0d681e3bab8cfdc76e3296589534dcda7b66362a/packages/remix-dev/cli/migrate/migrations/replace-remix-imports/transform/mapNormalizedImports/packageExports.ts#L81-L84 https://github.com/remix-run/remix/blob/536b326263d059aef7e63cc7363408ab10f509da/packages/remix-eslint-config/rules/packageExports.js#L60-L63

@mjackson I took the liberty of resolving all conversations here, so we can get this one merged

@nickytonline No hurry, just wanted to make sure this new adapter is aligned with all existing ones. I think it would also be a good idea to add tests to...