remix icon indicating copy to clipboard operation
remix copied to clipboard

feat(remix-dev): use native pnp resolution in esbuild 0.15+

Open redabacha opened this issue 2 years ago • 6 comments

Closes: #

  • [ ] Docs
  • [ ] Tests

Testing Strategy:

redabacha avatar Sep 07 '22 10:09 redabacha

🦋 Changeset detected

Latest commit: e715c19978d83de6b6a3f09af088359d262faf89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/deno Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/node Major
@remix-run/react Major
@remix-run/serve Major
@remix-run/server-runtime Major
@remix-run/vercel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 10:09 changeset-bot[bot]

i was hoping for this PR 🤩 - i know nothing about pnp though, so I'll defer to @pcattori - but if it's good, perhaps we can bump up to 0.15.9 to also include the jsx name collision fixes :)

mcansh avatar Sep 29 '22 22:09 mcansh

@redabacha Could you please rebase your branch onto latest dev & resolve conflicts?

MichaelDeBoey avatar Sep 29 '22 22:09 MichaelDeBoey

@mcansh : let's do some solid testing on the esbuild upgrade before we merge this

pcattori avatar Sep 29 '22 23:09 pcattori

100%

mcansh avatar Sep 29 '22 23:09 mcansh

I just upgraded my team's very small internal app to this P/R and no issues thus far. I'll update if we run into anything.

mattste avatar Sep 30 '22 17:09 mattste

This have been implemented in #4301 Thank you @redabacha!

machour avatar Nov 18 '22 22:11 machour