remix icon indicating copy to clipboard operation
remix copied to clipboard

feat(remix-cloudflare): rename `createCloudflareKVSessionStorage` to `createWorkersKVSessionStorage`

Open mjackson opened this issue 3 years ago • 4 comments

Rename to createWorkersKVSessionStorage for consistency with the "Workers KV" product name.

mjackson avatar Mar 29 '22 17:03 mjackson

@mjackson We should probably also add createWorkersKVSessionStorage to packageExports.ts in both replace-remix-imports migration & eslint-config

https://github.com/remix-run/remix/blob/0d681e3bab8cfdc76e3296589534dcda7b66362a/packages/remix-dev/cli/migrate/migrations/replace-remix-imports/transform/mapNormalizedImports/packageExports.ts#L81-L84

https://github.com/remix-run/remix/blob/536b326263d059aef7e63cc7363408ab10f509da/packages/remix-eslint-config/rules/packageExports.js#L60-L63

MichaelDeBoey avatar Apr 01 '22 15:04 MichaelDeBoey

@mjackson It seems like we have some conflicts to resolve here

MichaelDeBoey avatar Jun 02 '22 22:06 MichaelDeBoey

🦋 Changeset detected

Latest commit: e151816d92fd0240377b437003d7334e771246c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 25 '22 19:08 changeset-bot[bot]

@mjackson I took the liberty of resolving all conversations here, so we can get this one merged

MichaelDeBoey avatar Aug 25 '22 19:08 MichaelDeBoey

@mcansh @pcattori Anything that's preventing us from merging this one?

MichaelDeBoey avatar Jan 21 '23 14:01 MichaelDeBoey

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jan 24 '23 07:01 github-actions[bot]

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jan 30 '23 23:01 github-actions[bot]