Micha Reiser
Micha Reiser
Nice, thank you. Would you mind adding a few tests showing the fix? Are there cases where a comprehension would be preferred over `list.extend`. If so, then I don't think...
You can extend the existing tests. The testing framework runs your lint rule against the file and snapshots all created diagnostics with their fixes. https://github.com/astral-sh/ruff/blob/b34278e0cd25a24b69f4786897ca80c19fc3d5f1/crates/ruff_linter/src/rules/perflint/mod.rs#L20
> How should I deal with the existing test case? You would have to mark the rule as sometimes fixable. I suggest to add a `TODO` comment to the preview...
Hmm, what's up with the ecosystem check... Let's re-run to get a better sense of the changes
I suspect that the ecosystem check is panicking during the fix generation. Let me run it locally
Ah, that makes sense. This is great. Thank you so much for working on the fix
I updated the issue to reflect the `flake8-trio` to `flake8-async` rename, crossed of the new rules implemented in #10416, and added new rules to the list to match `flake8-async`'s documentation
Thanks. Such a rule does make sense to me but Ruff's current capabilities only allow this rule to provide precise results when the class has no base classes because it...
> If we do that, we'll still need a separate solution for red-knot diagnostics which are more disparate (or we'd have to use anstream over there). That's correct. Ideally we...
I suggest that we revisit this issue after we have the new diagnostic system in place.