Micha Reiser

Results 1092 comments of Micha Reiser

@GabDug thanks for the added perspective on this. My concern with removing the `v` prefix is that this is also likely to break existing tools and workflows. For example, wouldn't...

Thanks for reporting this. I just checked the [numpy release notes](https://numpy.org/devdocs/release/2.0.0-notes.html#numpy-2-0-python-api-removals) and they only mention the deprecation of `NaN` in favor of `nan`. Do you have a link to documentation...

The way this differs in my view from the numpy rule is that the NumPy rule was made more complete by including more of the deprecated methods. This PR introduces...

Looking at this more closely, it does seem consistent with how we handle redefinitions in function bodies. https://play.ruff.rs/39ccfb6f-b0d6-4674-9fa1-6982797166fc

The reason that the usage disables the warning is that `F811` only warns about symbols that get redefined but are never used. Adding `q = Empty()` adds a use to...

Scanning through the diff, it seems that most (all?) are related to the `libCST` dependency. Maybe a non-determinism in their macro?

That makes sense. Have you tried using a [hierarchical configuration](https://docs.astral.sh/ruff/configuration/#pyprojecttoml-discovery) to achieve your goal? The way this works is that you create a new `ruff.toml` in the test directory that...

> Really wishing we had ESLint-style file overrides, as in: > > ```json > { > "rules": { > "quotes": ["error", "double"] > }, > > "overrides": [ > {...

@irdkwmnsb you can already achieve that *if* all legacy files have a common ancestor directory by adding a `ruff.toml` in that ancestor directory. You need this feature if the files...

A fix would definitely be useful. I'm not convinced that we should include the error codes in the message. It could make the message unnecessarily long. But we could include...